Skip to content

Create rule S7009: Detect Scaleway secrets (APPSEC-1837) #4051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 15, 2024

Conversation

hashicorp-vault-sonar-prod[bot]
Copy link
Contributor

You can preview this rule here (updated a few minutes after each push).

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@hendrik-buchwald-sonarsource hendrik-buchwald-sonarsource changed the title Create rule S7009 Create rule S7009: Detect Scaleway secrets (APPSEC-1837) Jul 10, 2024
@hendrik-buchwald-sonarsource hendrik-buchwald-sonarsource marked this pull request as ready for review July 10, 2024 12:45
:example_name: scaleway-key
:example_env: SCALEWAY_KEY

include::../../../shared_content/secrets/examples.adoc[]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized that the example is missing an access key id, so it wouldn't raise an issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 1 minor nitpick.

Co-authored-by: Jamie Anderson <127742609+jamie-anderson-sonarsource@users.noreply.github.com>
Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@hendrik-buchwald-sonarsource hendrik-buchwald-sonarsource merged commit 648f741 into master Jul 15, 2024
12 checks passed
@hendrik-buchwald-sonarsource hendrik-buchwald-sonarsource deleted the rule/add-RSPEC-S7009 branch July 15, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants